fix: optimize_projections failure after mark joins created by EXISTS OR EXISTS#21265
Merged
berkaysynnada merged 4 commits intoapache:mainfrom Apr 17, 2026
Merged
Conversation
follow up on apache#17119
neilconway
approved these changes
Apr 6, 2026
Contributor
|
@alamb This PR looks reasonable to me. |
alamb
approved these changes
Apr 10, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me too - thanks @buraksenn and @neilconway
berkaysynnada
approved these changes
Apr 17, 2026
Contributor
berkaysynnada
left a comment
berkaysynnada
left a comment
There was a problem hiding this comment.
I've finally had a chance to take a look at this. LGTM, it's a clear fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Issue has details but main problem is mark columns from LeftMark joins leak into parent join schemas, causing
optimize_projectionsoptimizer to fail.What changes are included in this PR?
Add a projection after embedded subquery decorrelation to strip mark columns, following the same pattern as
scalar_subquery_to_join. I've seen this projection is merged in the final plan.Are these changes tested?
Added test case for reported failure
Are there any user-facing changes?
No.